Cloudwatch: Add back support for old Log Group picker #73524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
requested review from
fridgepoet and
iwysiu
and removed request for
a team
grafana-pr-automation
bot
added
area/frontend
area/backend
datasource/CloudWatch
labels
sarahzinger
added
no-backport
grafana-pr-automation
bot
added
area/backend
area/frontend
datasource/CloudWatch
labels
kevinwcyu
approved these changes
Aug 22, 2023
| logGroupLimit = intLimit | ||
| } | ||
|
|
||
| var response *cloudwatchlogs.DescribeLogGroupsOutput = nil |
There was a problem hiding this comment.
is there a reason this is a var on this line instead of it being on line 310?
response, err := logsClient.DescribeLogGroups(input)There was a problem hiding this comment.
no reason I can think of! I just copy and 🍝 from what we used to have but I like the suggestion! Changing now :)
iwysiu
approved these changes
Aug 22, 2023
sarahzinger
force-pushed
the
sarahzinger/bring-back-old-cloudwatch-logs-selector
branch
from
b0d7c2a
to
de4ee7f
Compare
sarahzinger
deleted the
sarahzinger/bring-back-old-cloudwatch-logs-selector
branch
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
sarahzinger
added a commit
that referenced
this pull request
Sep 18, 2023
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
sarahzinger
added a commit
that referenced
this pull request
Sep 19, 2023
* Cloudwatch: Add back support for old Log Group picker (#73524)
3 tasks
3 tasks
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When we Added Cross Account Observability to Cloudwatch Logs, we switched to a new log group picker.
This log group picker lets users select Log Groups across multiple accounts if available, and rather than save them by Log Group Name, we saved them by ARN, because Log Group Names do not have to be unique across aws accounts.
After some testing, we decided it seemed to be working well for users using Cross Account Observability and users who were not so we switched all users to the new Log Group Picker.
Unfortunately we learned after doing so that the aws api to query across log groups using log group arns is not supported in Gov Cloud just yet, and may not for sometime. This PR brings back the old Log Group Picker. Most users will continue to see the new Log Group Picker, however if users would like to revert to the old one, they now can by setting a feature flag in their custom.ini (or by making a support request if they are in Grafana Cloud)
Why do we need this feature?
To let AWS Gov Cloud upgrade to more recent versions of Grafana while still using Cloudwatch Logs.
Who is this feature for?
AWS Gov Cloud users
Which issue(s) does this PR fix?:
Fixes #71982
Special notes for your reviewer:
Please check that: